OAK-11506 Update oak-segment-azure tools to use azure sdk v12 implementation#2160
Merged
smiroslav merged 11 commits intoapache:trunkfrom Mar 19, 2025
Merged
OAK-11506 Update oak-segment-azure tools to use azure sdk v12 implementation#2160smiroslav merged 11 commits intoapache:trunkfrom
smiroslav merged 11 commits intoapache:trunkfrom
Conversation
ierandra
changed the title
…ntation - refactor AzurePersistenceManager
…ntation - fix unit tests
…ntation - fix unit tests
…ntation - remove AZURE_STORAGE_ACCOUNT_NAME
…ntation - remove AZURE_STORAGE_ACCOUNT_NAME
ierandra
commented
Mar 17, 2025
| * the directory to an existing segment store. | ||
| * @return the builder | ||
| */ | ||
| public Builder withRootPrefix(String rootPrefix) { |
Contributor
Author
There was a problem hiding this comment.
this is used in other projects when running compaction
smiroslav
reviewed
Mar 17, 2025
| BlobContainerClient targetContainer; | ||
| if (sourceBlobContainerClient != null && destinationBlobContainerClient != null) { | ||
| roPersistence = new AzurePersistence(sourceBlobContainerClient, rootPrefix); | ||
| rwPersistence = new AzurePersistence(destinationBlobContainerClient, rootPrefix); |
Contributor
There was a problem hiding this comment.
targetRootPrefix should be used
…ntation - PR review change
…/OAK-11506 # Conflicts: # oak-upgrade/src/test/java/org/apache/jackrabbit/oak/upgrade/cli/node/SegmentAzureFactoryTest.java
…ntation - PR review change
smiroslav
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OAK-11506 Update oak-segment-azure tools to use azure sdk v12 implementation